Combine render widget #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
refactor/combine-widget
branch
from
4e932e6
to
244afee
Compare
M-Adoo
requested review from
wjian23 and
sologeek
and removed request for
wjian23
…ader The writer of the render widget may not be flagged as dirty.
…hild Reimplemented `HAlignWidget`, `VAlignWidget`, `RelativeAnchor`, `BoxDecoration`, `ConstrainedBox`, `IgnorePoint`, `Opacity`, `Padding`, `TransformWidget`, and `VisibilityRender` as `WrapRender`.
M-Adoo
force-pushed
the
refactor/combine-widget
branch
from
244afee
to
3332e21
Compare
M-Adoo
added
B-test
wjian23
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this Pull Request
WrapRenderfor a render widget that combines with its child as a single widget tree node.HAlignWidget,VAlignWidget,RelativeAnchor,BoxDecoration,ConstrainedBox,IgnorePoint,Opacity,Padding,TransformWidget, andVisibilityRenderasWrapRender.-Checklist Before Merging
Please ensure the following are completed before merging:
CHANGELOG.mdfile.Breakingsection of theCHANGELOG.mdfile.Additional Information
The bot will replace
#prinCHANGELOG.mdwith your pull request number. If your branch is out of sync, usegit pull --rebaseto update it.If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.
If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.